Re-open stream when MMAP is disabled #2338
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flamme
reviewed
Jan 26, 2026
| // If the performance mode has changed, or if MMAP is disabled but currently used, | ||
| bool isMMapGlobal = isMMapEnabled(); | ||
| bool isMMapCurrentlyUsed = OboeExtensions::isMMapUsed(mAudioStream.get()); | ||
| if (performanceMode != mLastPerformanceMode || (!isMMapGlobal && isMMapCurrentlyUsed)) { |
Collaborator
There was a problem hiding this comment.
This may not be correct. If the mAudioStream is originally opened with mmap disabled and then the user reenable mmap, the stream should also be reopened.
Collaborator
Author
There was a problem hiding this comment.
Ah yes, just added the fix by making it global
flamme
approved these changes
Jan 26, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug where the stream would not restart if MMAP setting was changed